Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Rust node generation to a library #6

Open
philpax opened this issue Oct 18, 2024 · 0 comments
Open

Convert Rust node generation to a library #6

philpax opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@philpax
Copy link
Owner

philpax commented Oct 18, 2024

At present, rucomfyui_generate_nodes is a standalone application that will generate node definitions for the standard ComfyUI nodes. However, users (i.e. me) often have custom nodes that they would still like to use in a typed form.

We should refactor the code so that it will take arbitrary ObjectInfos and generate Rust code from them, and then allow use in a build script / macro so that you can easily paste in a definition and generate the code for use in your project.

The unanswered question is: how do we deal with custom types? We could have the macro define these, but I fear that there will be conflicting types. My current thinking is that we just use a separate macro to force the user to use their own common types. That should also allow them to define their own conversions if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant