Issue 642 - the cover rate of passes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #642.
Addresses #642.
Addresses #642.
Addresses #642.
KomaGR
requested changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks for the PR. Can you please make sure the code follows the coding conventions in https://github.com/phillipstanleymarbell/Noisy-lang-compiler/blob/master/README-CodingConventions.md ?
Comment on lines
116
to
117
| if (isa<GetElementPtrInst>(llvmIrInstruction) && isa<Argument>(llvmIrInstruction->getOperand(0))) | ||
| break; |
There was a problem hiding this comment.
Please always use brackets in if statements, even if there is only one statement in the conditional branch. See coding conventions here: https://github.com/phillipstanleymarbell/Noisy-lang-compiler/blob/master/README-CodingConventions.md
Comment on lines
131
to
137
| auto instType = llvmIrInstruction->getType(); | ||
| auto typeId = instType->getTypeID(); | ||
| if (typeId == Type::PointerTyID) | ||
| { | ||
| instType = instType->getPointerElementType(); | ||
| typeId = instType->getTypeID(); | ||
| } |
There was a problem hiding this comment.
Is indentation mismatched here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #642