Issue 628 - Type Shrinkage and Memory Alignment #630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type extremely Addresses #628.
KomaGR
requested changes
Nov 15, 2022
Addresses #628.
|
I reformated the files by |
KomaGR
requested changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks for the PR. Please make all code follows the coding conventions as specified in https://github.com/phillipstanleymarbell/Noisy-lang-compiler/blob/master/README-CodingConventions.md.
| sourceOperand->getType()->isIntegerTy()) | ||
| { | ||
| // float fa = (float)ia; | ||
| bool isSinged = sourceInst->getOpcode() == Instruction::SIToFP; |
There was a problem hiding this comment.
Should this be isSigned instead of isSinged?
| @@ -44,6 +44,7 @@ | |||
| #include <cmath> | |||
| #include <float.h> | |||
| #include <limits> | |||
| #include <math.h> | |||
There was a problem hiding this comment.
Why is this suddenly included here?
| @@ -245,7 +247,7 @@ getTypeInfo(State * N, Value * inValue, | |||
| switch (inInstType->getTypeID()) | |||
| { | |||
| case Type::IntegerTyID: | |||
| typeInformation = getShrinkIntType(N, inValue, vrRangeIt->second); | |||
| typeInformation = getShrinkIntType(N, inValue, vrRangeIt->second); | |||
There was a problem hiding this comment.
I think this is a mismatched indentation. Please also use brackets with switch cases.
|
The code base is super different. I merge the code manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for issue 628.
In this PR, I'm going to implement the type shrinkage with memory alignment.