Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of irPassDimensionalMatrixKernelPrinter since 4c25ee031ed43b96b4dfe64a42544c3692e0c401 #393

Open
phillipstanleymarbell opened this issue Jan 2, 2019 · 3 comments

Comments

@phillipstanleymarbell
Copy link
Owner

Describe the bug
The outputs of the irPassDimensionalMatrixKernelPrinter no longer make sense since the batch of commits between fc642c8 and 4c25ee0.

To Reproduce
Steps to reproduce the behavior, follow any of the following links which are to the CGI version that incorporates the recent changes (Newton version 0.2-alpha-679 (cb48118) (build 01-02-2019-14:[email protected]_64)):

Expected behavior
Since the current CGI version activates the following passes

	irPassDimensionalMatrixAnnotation(newtonCgiState);
	irPassDimensionalMatrixPiGroups(newtonCgiState);
	irPassDimensionalMatrixKernelRowCanonicalization(newtonCgiState);
	irPassDimensionalMatrixPiGroupSorted(newtonCgiState);
	irPassDimensionalMatrixPiGroupsWeedOutDuplicates(newtonCgiState);
	irPassDimensionalMatrixConvertToList(newtonCgiState);
	irPassDimensionalMatrixPrinter(newtonCgiState);
	irPassDimensionalMatrixKernelPrinter(newtonCgiState);

the expected behavior is a canonical form of Pis (i.e., either 'a/b' or 'b/a', but not both).

Screenshots
For ActivityClassifier.nt:
screen shot 2019-01-02 at 15 20 14

Desktop (please complete the following information):
N/A.

Smartphone (please complete the following information):
N/A.

Additional context
N/A.

@Siegfriedchao
Copy link
Contributor

Siegfriedchao commented Jan 3, 2019

Root cause: the printer IRs have not yet been updated to reflect the changes of the reordered kernels. Will update the newton-irPass-dimensionalMatrixPiGroupWeedOut to restore the nullspaces for printer IRs to use.

Quote from the Slack channel discussion: Youchao: Currently saving nullSpace, nullSpaceRowReordered, nullSpaceCanonicallyReordered and nullSpaceWithouDuplicates, so that they might be of use in the future. Phillip: The print routines should take the null space as a parameter, then can reuse

@Siegfriedchao
Copy link
Contributor

This is solved in #388 bundle updates.

Siegfriedchao added a commit that referenced this issue Jan 10, 2019
…(after #383 and #372) to suit dimensionalMatrixKernelPrinter

Addresses #388.
@phillipstanleymarbell
Copy link
Owner Author

Moving this to verify as the comments above imply this is fixed in #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants