Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in calculating the null space values #361

Open
Siegfriedchao opened this issue Sep 5, 2018 · 2 comments
Open

Error in calculating the null space values #361

Siegfriedchao opened this issue Sep 5, 2018 · 2 comments

Comments

@Siegfriedchao
Copy link
Contributor

Siegfriedchao commented Sep 5, 2018

When running the programme, using DragForce.nt, we obtain the following Kernel 0 value.

Kernel 0 is a new unique kernel

1.1259e+151.1259e+15  -0

   11.1259e+15-1.1259e+15

-2.2518e+15-1.1259e+15   0

1.1259e+15   0   0

   01.1259e+15   0

   0   01.1259e+15

Which is clearly not correct. The other kernels are fine.
An issue with the operation in multiplying by reciprocal of smallest coefficient, around Line 511 in newton-eigenLibraryInterface.cpp

When not performing the smallest coefficient multiplication, we have the following Kernel 0

 1   1  -0
8.88178e-16   1  -1
-2  -1   0
 1   0   0
 0   1   0
 0   0   1

Where a very small 8.88178e-16 exists, clearly affecting the finding the smallest coefficient operation.

@phillipstanleymarbell
Copy link
Owner

This is important to fix but is not a critical blocker at this point.

@phillipstanleymarbell
Copy link
Owner

To elaborate further on my comment: to fix this issue correctly, we would need to be computing the RREF symbolically rather than numerically. If we are computing it numerically, it is not trivial to address correctly and will require someone with a better grasp of numerical analysis than I have. Some pointers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants