Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement generics as wrappers of C++ std library functions #7241

Open
sardination opened this issue Sep 14, 2022 · 0 comments
Open

Reimplement generics as wrappers of C++ std library functions #7241

sardination opened this issue Sep 14, 2022 · 0 comments
Labels
cleanup Cleaning up and organizing our repositories devOps Improving or adding new tests & CI capabilities priority-5-low #5 Priority - Something that should happen eventually 📁 Repo: protocol This PR/Issue modifies /protocol code

Comments

@sardination
Copy link
Contributor

Feature Description
We have our own custom implementations of queue and linked list right now, but now that we have transitioned to a mix of C++ and C instead of just C, we can take advantage of the existing implementations of generics that C++ has.

The Problem It Fixes
We have less code to debug and maintain!

Potential Implementation(s)
Make fifo_queue a wrapper of std::deque and linked_list a wrapper of std::list.
@sardination sardination added the cleanup Cleaning up and organizing our repositories label Sep 14, 2022
@sardination sardination mentioned this issue Sep 14, 2022
Merged
3 tasks
@philippemnoel philippemnoel added priority-5-low #5 Priority - Something that should happen eventually devOps Improving or adding new tests & CI capabilities 📁 Repo: protocol This PR/Issue modifies /protocol code labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Cleaning up and organizing our repositories devOps Improving or adding new tests & CI capabilities priority-5-low #5 Priority - Something that should happen eventually 📁 Repo: protocol This PR/Issue modifies /protocol code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sardination @philippemnoel