Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the API of DACycle Presenter #17430

Open
Ducasse opened this issue Nov 23, 2024 · 0 comments
Open

Redesign the API of DACycle Presenter #17430

Ducasse opened this issue Nov 23, 2024 · 0 comments
Labels
Type: Cleanup Type: UX

Comments

@Ducasse
Copy link
Member

Ducasse commented Nov 23, 2024

#17429

the problem was that the application was SpNullApplication.
The changes proposed in #17429 use StPharoApplication current but it should not.
In fact the application should ask the application to create the presenter (and this should not be the presenter that gets the responsibility to set the application.
So we should change the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup Type: UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ducasse