Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Moose images download #535

Closed
demarey opened this issue Jan 18, 2022 · 3 comments
Closed

fix Moose images download #535

demarey opened this issue Jan 18, 2022 · 3 comments
Labels

Comments

@demarey
Copy link
Contributor

demarey commented Jan 18, 2022

Describe the bug
A change in GitHub releases url breaks Moose images download

See svenvc/zinc#69

Fix:

PhLDownloadManager>>#newHTTPClientForUrl: url
	^ ZnClient new
		signalProgress: true;
		url: url;
		enforceHttpSuccess: true;
		withOptions: [ :options | options at: #queryKeyValueSafeSet put: (ZnOptions queryKeyValueSafeSet \ '/;') ];
		ifFail: [ :exception | self downloadFailureForUrl: url ];
		yourself

It is need to load a new version of Zinc:

Metacello new
  repository: 'github://svenvc/zinc/repository';
  baseline: 'ZincHTTPComponents';
  load.
@demarey demarey added the Bug label Jan 18, 2022
demarey added a commit that referenced this issue Mar 15, 2022
@demarey demarey changed the title fix Mooose images download fix Moose images download Mar 15, 2022
@demarey demarey closed this as completed Mar 15, 2022
@fuhrmanator
Copy link
Contributor

I am using the latest PL 3.0 in Windows 10 and still hitting this problem. Is there maybe a zinc configuration issue?

Pharo Launcher version: 3.0

Pharo_8ZuIbPRZFu

I'd like to help write a test for this so the regression doesn't happen.

@fuhrmanator
Copy link
Contributor

Finally, I think it's a problem with the Moose releases on GitHub and the "Official releases" (the original one Moose9-development.zip doesn't actually exist anymore). I will create another issue (probably for Moose?). Somehow it would be nice to get a "Not found" error rather than a generic PhLDownloadError - the original Zinc issue was also the same manifestation, if I"m not mistaken.

@demarey
Copy link
Contributor Author

demarey commented Apr 15, 2022

Hi Christopher,

Thank you for the notification.
I updated the official sources to fix Moose urls and I also took some minutes to have a better display of http errors. The http error code and reason will now be displayed as well as the url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants