Fix pc_patch_compress leak (take 2) #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And call that function from all the different pc_patch_*_free functions.
pc_patch_free_stats should always be called with a valid patch.
|
Closes #111. |
mbredif
approved these changes
Apr 30, 2018
lib/pc_patch_uncompressed.c
Outdated
| @@ -215,6 +216,8 @@ pc_patch_uncompressed_compute_extent(PCPATCH_UNCOMPRESSED *patch) | |||
| void | |||
| pc_patch_uncompressed_free(PCPATCH_UNCOMPRESSED *patch) | |||
| { | |||
| pc_patch_free_stats((PCPATCH*) patch); | |||
|
|
|||
There was a problem hiding this comment.
As you removed the check in pc_patch_free_stats, maybe you can add assert(patch); here, just to be consistent across patch types
There was a problem hiding this comment.
Good point. I'll add that.
Nice picture by the way ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #112.
I've taken @achidlow's commits, squashed them together, and added three additional commits. My second commit renames the pc_patch_common_free function to pc_patch_free_stats, which is more explicit.
@mbredif can you please take a final look at this before I merge it and release 1.1.0?