Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #27

Open
ZXGuesser opened this issue Jan 12, 2020 · 2 comments
Open

Remove redundant code #27

ZXGuesser opened this issue Jan 12, 2020 · 2 comments
Labels

Comments

@ZXGuesser
Copy link
Collaborator

Purge irrelevant code carried over from editor.

  • Page saving is used in commented out debug code in SendSubtitle is this needed, would a simpler page dump suffice for debugging?
  • There is code for multiple formats but we only read tti. Do we want to (re)implement loading the other formats or should we throw them out? Affects Support for ETT (.ttp) file format #19
@peterkvt80
Copy link
Owner

Probably best to drop the irrelevant code. So get rid of page saving and formats other than tti..

@ZXGuesser
Copy link
Collaborator Author

That's chopped out a bunch of dead stuff in 0f6b2bb. There's no doubt more in code that I don't fully understand.
I notice there's duplication of page copying, could this be consolidated? I see that it's used by the subtitle stuff which I've never dug into enough to figure out how it all works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants