Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushAlerts not following sound settings #282

Open
sammargh opened this issue Jun 5, 2011 · 1 comment
Open

PushAlerts not following sound settings #282

sammargh opened this issue Jun 5, 2011 · 1 comment

Comments

@sammargh
Copy link
Contributor

sammargh commented Jun 5, 2011

If you setup a third party notification in settings and set it to not have sound mobilenotifier will still play a sound/vibrate regardless if you disable the sound.

I found my own method to disable all sound for third party push alerts as that's how I use my phone but that really isn't a workable solution, checking data.type == kPushAlert in MNWhistleBlower before executing the sound to skip the if statement.

I've tried trying to find where IOS stores the settings for notifications but my results of searching today have come up empty handed. I do know that once it is found it would be best to include inside the data array used to pass to MNWhistleBlower as a new variable such as data.sound as it would keep the code cleaner.

I'm not requesting a push of my code nor have I bothered committing it because it's a hack and isn't a fix. Any-who if someone wants to play ping-pong on finding out where this information resides I'm all ears.

@sammargh
Copy link
Contributor Author

sammargh commented Jul 7, 2011

While commit 9f77f00 addresses this issue it does exactly what I explained in my post here and isn't a fix, just a workaround. As far as I can tell RemoteNotificationClient has what is needed, it has an integer AppEnabledTypes which returns a value based on which settings the user has enabled in the notification center.

I am no good with Mobile Substrate but this variable would need to be passed to MobileNotifier to actually fix this issue properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant