Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using branches with floating numeric names #3493

Open
fernando-pcg opened this issue Nov 5, 2024 · 6 comments
Open

Error when using branches with floating numeric names #3493

fernando-pcg opened this issue Nov 5, 2024 · 6 comments

Comments

@fernando-pcg
Copy link

fernando-pcg commented Nov 5, 2024

Hello,

Error when using branches with floating numeric names

In my projects, branch names of the floating type are used, for example 15.0, 16.0, but the parameters do not allow this, when using these numbers it does not consider the .0 and it is not possible to change these names, so it does not find the branch, I also tried to put these names inside quotes but it gives another error.

Steps to reproduce

image Create the action with a branch with a floating name.

If this issue is describing a possible bug please provide (or link to) your GitHub Actions workflow.
image

@peter-evans
Copy link
Owner

Hi @fernando-pcg

This might be an issue with the yaml parsing on the runner. Could you try setting the base like this and see if it fixes it:

base: "16.0"

@peter-evans
Copy link
Owner

I also tried to put these names inside quotes but it gives another error

I just saw you already tried that. Could you share that error/log.

@peter-evans
Copy link
Owner

I've spotted another issue, which is probably the "another error" you mentioned. Setting the branch like this will not work.

branch: ${{ github.ref_name }}

Please see here for an explanation: https://github.com/peter-evans/create-pull-request/blob/main/docs/common-issues.md#create-using-an-existing-branch-as-the-pr-branch

@fernando-pcg
Copy link
Author

fernando-pcg commented Nov 5, 2024

Hi @fernando-pcg

This might be an issue with the yaml parsing on the runner. Could you try setting the base like this and see if it fixes it:

base: "16.0"

image
This is the error I get when trying with '16.0',
I can try it with the double quotes, but I guess it would be something similar, I'll try it anyway

Edit: Yep, got the same error

@peter-evans
Copy link
Owner

@fernando-pcg Using quotes is the correct way to avoid the original error you had. So please keep the quotes. 👍

The problem now is what I mentioned in this comment: #3493 (comment)

@fernando-pcg
Copy link
Author

@fernando-pcg Using quotes is the correct way to avoid the original error you had. So please keep the quotes. 👍

The problem now is what I mentioned in this comment: #3493 (comment)

Get it, im gonna look for a work around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants