Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rosbridge_suite and roslibjs #97

Open
amalnanavati opened this issue Nov 14, 2023 · 1 comment · May be fixed by #125
Open

Update rosbridge_suite and roslibjs #97

amalnanavati opened this issue Nov 14, 2023 · 1 comment · May be fixed by #125
Assignees

Comments

@amalnanavati
Copy link
Contributor

Upstream changes to make rosbridge_suite compatible with ROS2 actions have already been merged in, and there is an open PR to do the same for roslibjs. Once that is merged in, we should update our system to use the upstream code. (Note: we have to use this together, because there were some additional changes in the upstream PR for rosbridge_suite e.g., renaming send_goal to send_action_goal.)

@amalnanavati amalnanavati self-assigned this Nov 14, 2023
@amalnanavati amalnanavati linked a pull request Nov 14, 2023 that will close this issue
21 tasks
@amalnanavati amalnanavati removed a link to a pull request Nov 14, 2023
21 tasks
@amalnanavati
Copy link
Contributor Author

amalnanavati commented Feb 19, 2024

Update: although ROS2 actions support has been merged into rosbridge and roslibjs, there is still a lingering issue where asynchronous action cancellation is not possible if that action was also initiated by the web app. Thus, we have to wait until that issue is resolved before switching to the upstream code.

@amalnanavati amalnanavati linked a pull request Feb 19, 2024 that will close this issue
6 tasks
@amalnanavati amalnanavati linked a pull request Feb 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant