Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory for models #45

Open
perlindgren opened this issue Jul 27, 2023 · 5 comments
Open

Directory for models #45

perlindgren opened this issue Jul 27, 2023 · 5 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@perlindgren
Copy link
Owner

Problem:

For now the examples generates .json and .gv files in the top level folder. This might not be ideal, as the project gets a bit harder to navigate.

Solution:

We put the generated models somewhere else. The question is where? Some alternatives.

  • A models folder at top level.

  • Use the target folder (possibly with a ./target/models path).

What's your opinion?

@perlindgren perlindgren added enhancement New feature or request question Further information is requested labels Jul 27, 2023
@onsdagens
Copy link
Collaborator

I think leaving ./target untouched is probably a good idea. Maybe the first option, or making the user choose a workspace directory at startup (either via dialog or a flag)? This could be saved in some sort of config so the choice persists until changed...

@perlindgren
Copy link
Owner Author

This is only the examples, so its intended for devs of SyncRim only, just for checking how the serialization of a particular model would look like, so I think keeping a fixed path would be good enough.

@onsdagens
Copy link
Collaborator

that's fair, i agree.

@perlindgren
Copy link
Owner Author

Using the target directory is also not completely crazy as its a compilation artifact, but I'm not sure

@onsdagens
Copy link
Collaborator

Personally i don't know if i'd think to look there, i think a separate directory for SyncRim artifacts makes the most sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants