You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In percy/core/dist/config.js and percy/cli-upload/dist/upload.js
Percy defines a maximum limit of 2000 pixels for both screen/viewport width as well as minHeight.
As a consequence, the maximum device screen size I can set for headless chrome is 2000x2000 px.
However, today 4K monitors are already common for desktops and even larger ones exist.
With the current limits, it's not possible to explicitly test the behaviour and/or look of pages on such a screen.
In addition, being able to define a super tall minHeight would also solve a lot of other issues with Javascript/CSS-based dynamic or moving elements - like lazy loading, floating sticky headers etc.
Currently Percy will by default screenshot a web page in 1024 pixel-high chunks, and then stitch them together. This typically causes issues with the mentioned elements, forcing QA to use all kinds of "hacks" to put the dom/JS/CSS in a specific state before taking the screenshot.
A much easier approach is to simply define a super tall screen, so the whole height of the page fits on it: no scrolling required, by definition no content below the fold, everything is visible directly in the first page load.
As a result the screenshot would be "clean" without the need for any hacks.
The current 2000px limitation in Percy prevents that.
Product / feature request:
Please increase the limits to at least 20.000 px - to support current screen sizes.
Side note: simply editing the values in percy/core/dist/config.js and percy/cli-upload/dist/upload.js does not fix this, because it seems there is a server-side sanity check in the Percy cloud as well which throws an error for values larger than this limit.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In
percy/core/dist/config.js
andpercy/cli-upload/dist/upload.js
Percy defines a maximum limit of 2000 pixels for both screen/viewport width as well as minHeight.
As a consequence, the maximum device screen size I can set for headless chrome is 2000x2000 px.
However, today 4K monitors are already common for desktops and even larger ones exist.
With the current limits, it's not possible to explicitly test the behaviour and/or look of pages on such a screen.
In addition, being able to define a super tall minHeight would also solve a lot of other issues with Javascript/CSS-based dynamic or moving elements - like lazy loading, floating sticky headers etc.
Currently Percy will by default screenshot a web page in 1024 pixel-high chunks, and then stitch them together. This typically causes issues with the mentioned elements, forcing QA to use all kinds of "hacks" to put the dom/JS/CSS in a specific state before taking the screenshot.
A much easier approach is to simply define a super tall screen, so the whole height of the page fits on it: no scrolling required, by definition no content below the fold, everything is visible directly in the first page load.
As a result the screenshot would be "clean" without the need for any hacks.
The current 2000px limitation in Percy prevents that.
Product / feature request:
Please increase the limits to at least 20.000 px - to support current screen sizes.
Side note: simply editing the values in percy/core/dist/config.js and percy/cli-upload/dist/upload.js does not fix this, because it seems there is a server-side sanity check in the Percy cloud as well which throws an error for values larger than this limit.
Beta Was this translation helpful? Give feedback.
All reactions