Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vendor prefix to --vh CSS variable #160

Open
drichar opened this issue Feb 13, 2024 · 0 comments
Open

Add vendor prefix to --vh CSS variable #160

drichar opened this issue Feb 13, 2024 · 0 comments

Comments

@drichar
Copy link

drichar commented Feb 13, 2024 •
edited
Loading

In https://github.com/perawallet/connect/blob/main/src/util/screen/screenSizeUtils.ts the library sets a CSS variable named --vh on the root <html> element.

Having a third-party library set a generic, commonly used variable like --vh is a recipe for conflicts. In my app I'm adding my own logic for calculating its value and noticed it was being overwritten by some dependency, forcing me to search them one by one to find the culprit.

A better solution would be to add a prefix to this (or any) global CSS variable set by Pera Connect, e.g., --pera-vh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drichar