Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate JWT at the correct time #385

Open
nsheff opened this issue Sep 3, 2024 · 0 comments
Open

Evaluate JWT at the correct time #385

nsheff opened this issue Sep 3, 2024 · 0 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Sep 3, 2024

This issue is a spinoff of #377.

Right now, we're evaluating the JWT (including checking for an expired token) even for public requests. This is because we evaluate the JWT if it's given, in the dependencies.

Instead, we should restructure this to do the JWT validation only if something private was requested. So whether we evaluate the JWT shouldn't be modulated at the level of endpoints; it should instead be at the level of privacy-vs-not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant