Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping the /src/ #762

Closed
Tracked by #729
grod220 opened this issue Mar 14, 2024 · 2 comments
Closed
Tracked by #729

Dropping the /src/ #762

grod220 opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
deps update Update of project dependencies infra Low-level infrastructure updates

Comments

@grod220
Copy link
Contributor

grod220 commented Mar 14, 2024

In #672 we removed a number of barrel files. While this is more performant, we are now appending /src/ to a bunch of imports:

import { createChannelTransport } from '@penumbra-zone/transport-dom/src/create';

It would be nice to be able to drop this and have:

import { createChannelTransport } from '@penumbra-zone/transport-dom/create';

Also, this is largely not an issue with external code imports as they can do:

    "exports": {
      ".": "./dist/prax.js",
      "./global": "./dist/global.js",
      "./get-port": "./dist/get-port.js"
    }

However, doing like so with internal code renders a type error

    "exports": {
      ".": "./src/prax.ts",
      "./global": "./src/global.ts",
      "./get-port": "./src/get-port.ts"
    }
@grod220 grod220 added deps update Update of project dependencies infra Low-level infrastructure updates labels Mar 14, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Mar 14, 2024
@turbocrime
Copy link
Contributor

this can be handled by publishConfig

@turbocrime
Copy link
Contributor

there's actually a couple of these left, have some local work on it

@grod220 grod220 closed this as completed May 28, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Update of project dependencies infra Low-level infrastructure updates
Projects
Archived in project
Development

No branches or pull requests

2 participants