Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tx details page for swap + swap claim nicer #424

Closed
Tracked by #389
grod220 opened this issue Jan 29, 2024 · 4 comments · Fixed by #858
Closed
Tracked by #389

Make tx details page for swap + swap claim nicer #424

grod220 opened this issue Jan 29, 2024 · 4 comments · Fixed by #858
Assignees
Labels
ui Related to user interface or ux design

Comments

@grod220
Copy link
Contributor

grod220 commented Jan 29, 2024

No description provided.

@grod220 grod220 mentioned this issue Jan 29, 2024
16 tasks
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jan 29, 2024
@grod220 grod220 added the ui Related to user interface or ux design label Jan 29, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Feb 15, 2024
@hdevalence
Copy link
Member

We'll want to augment the protos to support this: penumbra-zone/penumbra#3832

Proposal for rendering of swap actions:

[VARIANT A: output NoteViews are present]
Swap
(L) 123.45 UM --> (L) 38.23 USDC { + (L) 12.78 UM [if unfilled inputs]}
{ if claim_tx is set: Claimed in fefe...fefe (link) }

[VARIANT B: output NoteViews are not present]
Swap
(L) 123.45 UM --> (L) USDC

Here (L) represents a circular logo. Ideally this would be handled by a single component.

In the component code, we'd probably want to actually have two "rows", one for each direction, with each row displayed conditionally on having nonzero inputs. (At the protocol level, it's technically possible to create a swap that swaps both directions simultaneously, though no software we have would ever do this).

For the swap claim view, we can just show the output note(s).

@hdevalence
Copy link
Member

hdevalence commented Feb 16, 2024

Proposed steps:

  • Extend TransactionPerspective to include the data that is needed to fill in the fields added in Augment SwapView, SwapClaimView with additional information penumbra#3832
  • Fill in support in Rust stack for the new fields in the SwapView and TransactionPerspective: the batch swap output data etc in the TransactionPerspective needs to be correctly inserted when using the perspective to generate a TransactionView
  • Pull in updated Rust code as a wasm dep, rebuild
  • Change extension typescript code to insert the new additional data into the TransactionPerspective it uses to generate the view
  • Change to dynamically-computed TransactionViews #557

@hdevalence
Copy link
Member

Similar structure to penumbra-zone/penumbra#3838

Not sure how we want to augment the perspective to have the output notes. Currently we have a general purpose "advice" set, but this only allows looking up notes by commitment and the original Swap doesn't have commitments to its eventual outputs. Transactions can have multiple swaps, so maybe we need a mapping from swap commitment => pairs of output notes?

@jessepinho jessepinho self-assigned this Feb 21, 2024
@jessepinho jessepinho moved this from 📝 Todo to 🏗 In progress in Penumbra web Feb 21, 2024
@jessepinho jessepinho removed their assignment Feb 21, 2024
@jessepinho jessepinho moved this from 🏗 In progress to 🛑 Blocked in Penumbra web Feb 21, 2024
@jessepinho
Copy link
Contributor

Moving to blocked for now, as there's quite a bit of work that needs to be done before this ticket can be completed.

@grod220 grod220 moved this from 🛑 Blocked to 📝 Todo in Penumbra web Mar 14, 2024
@jessepinho jessepinho moved this from 📝 Todo to 🏗 In progress in Penumbra web Mar 15, 2024
@grod220 grod220 added the mainnet label Apr 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to user interface or ux design
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants