-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tx details page for swap + swap claim nicer #424
Comments
We'll want to augment the protos to support this: penumbra-zone/penumbra#3832 Proposal for rendering of swap actions:
Here (L) represents a circular logo. Ideally this would be handled by a single component. In the component code, we'd probably want to actually have two "rows", one for each direction, with each row displayed conditionally on having nonzero inputs. (At the protocol level, it's technically possible to create a swap that swaps both directions simultaneously, though no software we have would ever do this). For the swap claim view, we can just show the output note(s). |
Proposed steps:
|
Similar structure to penumbra-zone/penumbra#3838 Not sure how we want to augment the perspective to have the output notes. Currently we have a general purpose "advice" set, but this only allows looking up notes by commitment and the original |
Moving to blocked for now, as there's quite a bit of work that needs to be done before this ticket can be completed. |
No description provided.
The text was updated successfully, but these errors were encountered: