Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify visible and opaque TxV / translators for auctions #1319

Closed
Tracked by #875
TalDerei opened this issue Jun 18, 2024 · 0 comments
Closed
Tracked by #875

modify visible and opaque TxV / translators for auctions #1319

TalDerei opened this issue Jun 18, 2024 · 0 comments
Assignees
Labels
rpc Related to proto rpc services/methods ui Related to user interface or ux design

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Jun 18, 2024

Referencing https://github.com/penumbra-zone/web/pull/1041/files#diff-3e744d2ab8ce04a85b15dc5bdef5573655ddfe9aed91fb38b01c11744ec1336eR87-R98, modify ActionDutchAuctionSchedule and ActionDutchAuctionEnd action views to display more descriptive information about each action. Currently, only the input / output metadata is being rendered to the user.

ActionDutchAuctionWithdraw will not be modified, and is currently shelved: penumbra-zone/penumbra#4219.

Previously, we were only displaying the input / output metadata to the user, which was sufficient for our purposes. We can, however, expand the metadata showed in the approval dialogue to be richer and shower more information to the user about their auctions. All the fields are opaque, so there's no risk of a privacy leak.
cc @jessepinho


update: on further reflection, the only other relevant field we should display is the auction ID. With our eventual push towards #1394, the approval dialogue is expressive enough.

@TalDerei TalDerei added the ui Related to user interface or ux design label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jun 18, 2024
@TalDerei TalDerei added this to Labs web Jul 1, 2024
@TalDerei TalDerei moved this to 📝 Todo in Labs web Jul 1, 2024
@TalDerei TalDerei self-assigned this Jul 1, 2024
@TalDerei TalDerei added the rpc Related to proto rpc services/methods label Jul 5, 2024
@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Labs web Jul 9, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Jul 17, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc Related to proto rpc services/methods ui Related to user interface or ux design
Projects
Archived in project
Development

No branches or pull requests

1 participant