Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect wallet method #1192

Closed
Tracked by #1194
grod220 opened this issue May 28, 2024 · 0 comments · Fixed by #1307
Closed
Tracked by #1194

Disconnect wallet method #1192

grod220 opened this issue May 28, 2024 · 0 comments · Fixed by #1307
Assignees
Labels
infra Low-level infrastructure updates

Comments

@grod220
Copy link
Contributor

grod220 commented May 28, 2024

Across crypto, wallets expose a disconnect() method to allow the user the ability to revoke sharing data with a web app (from the context of the web app itself). This is also consistent with cosmos wallets (see cosmos-kit and graz).

Task: add a disconnect() method to the injected Penumbra provider:

export interface PenumbraInjection {
readonly connect: () => Promise<MessagePort>;
readonly request: () => Promise<void>;
readonly isConnected: () => boolean | undefined;
readonly manifest: string;
}

This will allow for better integrations with external partners: #1190

Approve vs connect

Also, in other wallets, these are two different states:

  • approved: user has added website to connection whitelist
  • connected: user has granted permission to share data

I find this distinction a little confusing and largely unnecessary. For Prax, we basically have treated these as one. Relating to disconnect(), we can probably feel free to remove the domain from the whitelist as well.

@grod220 grod220 added the infra Low-level infrastructure updates label May 28, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web May 28, 2024
@turbocrime turbocrime self-assigned this May 29, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Penumbra web May 30, 2024
@turbocrime turbocrime moved this from 📝 Todo to 🏗 In progress in Penumbra web May 30, 2024
This was referenced Jun 9, 2024
@grod220 grod220 added this to Labs web Jun 20, 2024
@grod220 grod220 moved this to 🏗 In progress in Labs web Jun 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jun 27, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Low-level infrastructure updates
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants