Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace atty with std::io::IsTerminal #3907

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: replace atty with std::io::IsTerminal #3907

merged 1 commit into from
Mar 1, 2024

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Feb 28, 2024

Resolves GHSA-g98v-hv3f-hcfr.

std::io::IsTerminal has been present since Rust 1.70.

cratelyn
cratelyn approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this @kevinji!

@cratelyn cratelyn merged commit f410d39 into penumbra-zone:main Mar 1, 2024
6 checks passed
@kevinji kevinji deleted the remove-atty branch March 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinji @cratelyn