Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete penumbra_proto::serializers code #4949

Open
hdevalence opened this issue Dec 2, 2024 · 0 comments
Open

Delete penumbra_proto::serializers code #4949

hdevalence opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
A-node Area: System design and implementation for node software

Comments

@hdevalence
Copy link
Member

Is your feature request related to a problem? Please describe.

Long, long ago, Penumbra attempted to do "shaping" of JSON (e.g., encoding an address as a string). This was quickly discovered to be unworkable and a bad idea, because it meant that there was no longer a single source of truth (vs using ProtoJSON). However, the legacy of this code lives on in the serializers module, which should be deleted.

That code is still depended on as the source of truth for various Bech32m prefixes, which should move to the keys crate (or wherever else the relevant data is defined).

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Dec 2, 2024
@erwanor erwanor removed the needs-refinement unclear, incomplete, or stub issue that needs work label Dec 3, 2024
@erwanor erwanor self-assigned this Dec 3, 2024
@erwanor erwanor added the A-node Area: System design and implementation for node software label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: System design and implementation for node software
Projects
None yet
Development

No branches or pull requests

2 participants