Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fees: validator definition submission broken #4541

Closed
Tracked by #4545
conorsch opened this issue Jun 4, 2024 · 2 comments
Closed
Tracked by #4545

fees: validator definition submission broken #4541

conorsch opened this issue Jun 4, 2024 · 2 comments
Labels
A-fees Area: Relates to transaction fees C-bug Category: a bug needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@conorsch
Copy link
Contributor

conorsch commented Jun 4, 2024

Since enabling fees in #4306, we've observed that submitting a validator definition fails:

❯ pcli validator definition upload --file val.toml
Scanning blocks from last sync height 386996 to latest height 386996
[0s] ██████████████████████████████████████████████████       0/0       0/s ETA: 0s
building transaction [1 actions, 0 proofs]...
finished proving in 0.002 seconds [1 actions, 0 proofs, 605 bytes]
broadcasting transaction and awaiting confirmation...
Error: error broadcasting transaction

Caused by:
    status: Internal, message: "Error submitting transaction: code 1, log: failed to deliver transaction: check_stateful failed: fee must be greater than or equal to the transaction base price (supplied: 0, base: 668)", details: [], metadata: MetadataMap { headers: {} }

Let's fix and point-release.

@conorsch conorsch added C-bug Category: a bug A-fees Area: Relates to transaction fees labels Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 4, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 4, 2024
@conorsch
Copy link
Contributor Author

conorsch commented Jun 4, 2024

Resolved by #4554

@conorsch conorsch closed this as completed Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Jun 4, 2024
@conorsch
Copy link
Contributor Author

conorsch commented Jun 4, 2024

Confirmed working on v0.77.2:

❯ pcli validator definition upload --file val.toml
Scanning blocks from last sync height 391454 to latest height 391454
[0s] ██████████████████████████████████████████████████       0/0       0/s ETA: 0s
building transaction [3 actions, 2 proofs]...
finished proving in 3.372 seconds [3 actions, 2 proofs, 2196 bytes]
broadcasting transaction and awaiting confirmation...
transaction broadcast successfully: c63883ebe047ada4d13e70e9920e2990993d90779136563217b544ed169d4bab
transaction confirmed and detected: c63883ebe047ada4d13e70e9920e2990993d90779136563217b544ed169d4bab
Uploaded validator definition

notified at least one community validator in discord who asked about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fees Area: Relates to transaction fees C-bug Category: a bug needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Archived in project
Development

No branches or pull requests

1 participant