Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auctions: 🔎 circle back on #4362 review comments #4366

Closed
cratelyn opened this issue May 9, 2024 · 1 comment · Fixed by #4378
Closed

auctions: 🔎 circle back on #4362 review comments #4366

cratelyn opened this issue May 9, 2024 · 1 comment · Fixed by #4378
Assignees
@cratelyn
Labels
A-auction Area: Relates to the auction component _P-low Priority: low
Milestone
Sprint 6

Comments

@cratelyn
Copy link
Contributor

cratelyn commented May 9, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

to help get the v0.74.0 release out the door promptly, we merged #4362 optimistically.

Describe the solution you'd like

we should circle back on the "gradual" dutch auction support in pcli and address these review comments.
@cratelyn cratelyn added the A-auction Area: Relates to the auction component label May 9, 2024
@cratelyn cratelyn added this to Penumbra May 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra May 9, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label May 9, 2024
@cratelyn
Copy link
Contributor Author

cratelyn commented May 9, 2024

see #4302.

@erwanor erwanor added _P-low Priority: low and removed needs-refinement unclear, incomplete, or stub issue that needs work labels May 10, 2024
@cratelyn cratelyn mentioned this issue May 10, 2024
Merged
@cratelyn cratelyn self-assigned this May 10, 2024
@cratelyn cratelyn moved this from Backlog to Done in Penumbra May 10, 2024
@cratelyn cratelyn moved this from Done to In progress in Penumbra May 10, 2024
@cratelyn cratelyn added this to the Sprint 6 milestone May 10, 2024
erwanor pushed a commit that referenced this issue May 13, 2024
@cratelyn
pcli(auction): 🩹 improve error message (#4378)
3fe73eb 
fixes #4366.

-
#4362 (comment)
-
#4362 (comment)
-
#4362 (comment)
-
#4362 (comment)
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cratelyn cratelyn

Labels
A-auction Area: Relates to the auction component _P-low Priority: low
Projects
Penumbra
Archived in project
Milestone
Sprint 6
Development

Successfully merging a pull request may close this issue.

misc: 🩹 apply some review suggestions penumbra-zone/penumbra
2 participants
@erwanor @cratelyn