Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auction: define and emit events #4303

Closed
3 tasks
Tracked by #4196
erwanor opened this issue May 2, 2024 · 0 comments · Fixed by #4353
Closed
3 tasks
Tracked by #4196

auction: define and emit events #4303

erwanor opened this issue May 2, 2024 · 0 comments · Fixed by #4353
Assignees
@erwanor
Labels
A-auction Area: Relates to the auction component
Milestone
Sprint 6

Comments

@erwanor
Copy link
Member

erwanor commented May 2, 2024 •
edited
Loading

We want to define three types of events

  • EventDutchAuctionScheduled
  • EventDutchAuctionUpdated
  • EventDutchAuctionEnded

Each tracking sufficient data so that an explorer can cross-ref auction activity with position management happening on the dex.
@erwanor erwanor mentioned this issue May 2, 2024
Open
50 tasks
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra May 2, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label May 2, 2024
@cratelyn cratelyn added the A-auction Area: Relates to the auction component label May 6, 2024
@erwanor erwanor self-assigned this May 6, 2024
@erwanor erwanor removed the needs-refinement unclear, incomplete, or stub issue that needs work label May 6, 2024
@erwanor erwanor added this to the Sprint 6 milestone May 6, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra May 6, 2024
@erwanor erwanor moved this from Todo to In progress in Penumbra May 8, 2024
@erwanor erwanor mentioned this issue May 8, 2024
Merged
1 task
erwanor added a commit that referenced this issue May 8, 2024
@erwanor
auction: define and record events (#4353)
099e9ea 
## Describe your changes

This PR adds three messages to the `v1alpha1` auction interface:
- `EventDutchAuctionScheduled`
- `EventDutchAuctionUpdated`
- `EventDutchAuctionEnded`

## Issue ticket number and link

Fixes #4303.

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> this only makes additive changes, recording events in the auction
component.
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
A-auction Area: Relates to the auction component
Projects
Penumbra
Archived in project
Milestone
Sprint 6
Development

Successfully merging a pull request may close this issue.

auction: define and record events penumbra-zone/penumbra
2 participants
@erwanor @cratelyn