Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

final circuit changes #4280

Closed
3 tasks done
redshiftzero opened this issue Apr 28, 2024 · 0 comments · Fixed by #4371
Closed
3 tasks done

final circuit changes #4280

redshiftzero opened this issue Apr 28, 2024 · 0 comments · Fixed by #4371
Assignees
@redshiftzero
Labels
A-zkproofs Area: Design and implementation of ZK-SNARKs for Penumbra _P-high High priority
Milestone
Sprint 6

Comments

@redshiftzero
Copy link
Member

redshiftzero commented Apr 28, 2024 •
edited
Loading

This is a tracking issue for any remaining changes to the circuits. These should be done in one changeset and the proving keys regenerated.

  • put B_d != id check into the AddressVar (see discord discussion here). Currently we include a check that the diversified base is not integrity separately, but to avoid forgetting this check, it would be prudent to include everywhere an AddressVar is allocated
  • Move the check that ak is not identity into AllocVar for AuthorizationKeyVar (same logic as above, ensure that this critical check cannot be left out)
  • use enforce_not_equal here
@redshiftzero redshiftzero added the A-zkproofs Area: Design and implementation of ZK-SNARKs for Penumbra label Apr 28, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 28, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 28, 2024
@redshiftzero redshiftzero mentioned this issue May 6, 2024
Merged
1 task
@redshiftzero redshiftzero added this to the Sprint 6 milestone May 6, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra May 6, 2024
@aubrika aubrika added _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels May 8, 2024
redshiftzero added a commit that referenced this issue May 9, 2024
@redshiftzero @cronokirby
spec: updates per internal feedback (#4334)
8627659 
## Describe your changes

This PR contains protocol spec changes from internal feedback

## Issue ticket number and link

Related to #4280 
Closes #4342

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > spec only

---------

Signed-off-by: Lúcás Meier <[email protected]>
Co-authored-by: Lúcás Meier <[email protected]>
@redshiftzero redshiftzero self-assigned this May 9, 2024
@redshiftzero redshiftzero moved this from Todo to In progress in Penumbra May 9, 2024
@redshiftzero redshiftzero mentioned this issue May 9, 2024
Merged
1 task
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
A-zkproofs Area: Design and implementation of ZK-SNARKs for Penumbra _P-high High priority
Projects
Penumbra
Archived in project
Milestone
Sprint 6
Development

Successfully merging a pull request may close this issue.

final changes to circuits penumbra-zone/penumbra
2 participants
@redshiftzero @aubrika