Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance script to support mac binary installation for cometBFT #4264

Open
TalDerei opened this issue Apr 24, 2024 · 0 comments
Open

Enhance script to support mac binary installation for cometBFT #4264

TalDerei opened this issue Apr 24, 2024 · 0 comments
Assignees
@conorsch
Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. _P-low Priority: low

Comments

@TalDerei
Copy link
Collaborator

TalDerei commented Apr 24, 2024 •
edited
Loading

We currently have a utility script designed to download and install a specific version of CometBFT for use with Penumbra, primarily in CI environments. This script is tailored to Linux systems and does not support macOS, especially the newer Darwin Arm64 architecture.

Enhance the existing script to automatically detect the operating system and architecture (x86-64 for Intel and Arm64 for M1/M2/M3 chips) of the user’s machine, and download the appropriate binary for macOS alongside the existing support for Linux.

The alternative is downloading the proper cometBFT binary version for Arm64 from source.

cc @conorsch
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 24, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 24, 2024
@TalDerei TalDerei added A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. labels Apr 24, 2024
@aubrika aubrika added _P-low Priority: low and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 24, 2024
@conorsch conorsch self-assigned this Apr 26, 2024
@conorsch conorsch mentioned this issue May 23, 2024
Merged
1 task
conorsch added a commit that referenced this issue Jul 15, 2024
@conorsch
ci: support macos in "install-cometbft" script
944e79d 
Flagged by @TalDerei as a nice-to-have during a recent pairing session.
Closes #4264.
@conorsch conorsch mentioned this issue Jul 15, 2024
Closed
1 task
conorsch added a commit that referenced this issue Jul 15, 2024
@conorsch
ci: support macos in "install-cometbft" script
3d7d461 
Flagged by @TalDerei as a nice-to-have during a recent pairing session.
Closes #4264.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. _P-low Priority: low
Projects
Penumbra
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: support macos in "install-cometbft" script penumbra-zone/penumbra
3 participants
@conorsch @TalDerei @aubrika