Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcli: query an auction state by id #4243

Closed
2 tasks done
Tracked by #4196
erwanor opened this issue Apr 19, 2024 · 1 comment
Closed
2 tasks done
Tracked by #4196

pcli: query an auction state by id #4243

erwanor opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Milestone

Comments

@erwanor
Copy link
Member

erwanor commented Apr 19, 2024

First, we need to create scaffolding for the command:

  • pcli q auction id AUCTION_ID

Then, we fill in the implementation to make a gRPC query and render its response:

  • pcli q auction id AUCTION_ID
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 19, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 19, 2024
@erwanor erwanor moved this from Backlog to Todo in Penumbra Apr 19, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 19, 2024
@erwanor erwanor added _P-V1 Priority: slated for V1 release A-auction Area: Relates to the auction component _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 19, 2024
@TalDerei TalDerei self-assigned this Apr 20, 2024
@TalDerei
Copy link
Collaborator

will remain blocked until view server support (tracked by #4251) is complete.

@cratelyn cratelyn moved this from Todo to Blocked in Penumbra Apr 22, 2024
@cratelyn cratelyn modified the milestones: Sprint 4, Sprint 5 Apr 22, 2024
@cronokirby cronokirby moved this from Blocked to In progress in Penumbra Apr 30, 2024
@cronokirby cronokirby moved this from In progress to Todo in Penumbra Apr 30, 2024
erwanor added a commit that referenced this issue May 1, 2024
## Describe your changes

This improve rendering of query/view subcommands for DAs. Helpful for
testing and integration work.

Closes #4242, #4243, #4244

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Client changes
@aubrika aubrika moved this from Todo to In progress in Penumbra May 1, 2024
@erwanor erwanor closed this as completed May 1, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Archived in project
Development

No branches or pull requests

3 participants