Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcli: support for auction interactions #4242

Closed
6 tasks done
Tracked by #4196
erwanor opened this issue Apr 19, 2024 · 2 comments · Fixed by #4297
Closed
6 tasks done
Tracked by #4196

pcli: support for auction interactions #4242

erwanor opened this issue Apr 19, 2024 · 2 comments · Fixed by #4297
Assignees
@TalDerei
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Milestone
Sprint 5

Comments

@erwanor
Copy link
Member

erwanor commented Apr 19, 2024 •
edited
Loading

We should add support for, the work can be divided in two phases:

Phase 1: add CLI scaffolding for:

  • pcli tx auction dutch schedule
  • pcli tx auction dutch end
  • pcli tx auction dutch withdraw

Phase 2: fill in the specific implementations:

  • pcli tx auction dutch schedule
  • pcli tx auction dutch end
  • pcli tx auction dutch withdraw

The item to prioritize is tx auction dutch schedule, so that we can work towards viewing capabilities.
@erwanor erwanor mentioned this issue Apr 19, 2024
Open
50 tasks
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 19, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 19, 2024
@erwanor erwanor added _P-V1 Priority: slated for V1 release _P-high High priority A-auction Area: Relates to the auction component and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 19, 2024
@erwanor erwanor moved this from Backlog to Todo in Penumbra Apr 19, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 19, 2024
@TalDerei TalDerei self-assigned this Apr 19, 2024
@TalDerei TalDerei mentioned this issue Apr 19, 2024
Merged
1 task
@TalDerei
Copy link
Collaborator

pcli implementations are currently only stubbed with planner-related boilerplate.

@TalDerei
Copy link
Collaborator

phase 1 is tracked by #4249. phase 2 will be completed in a separate PR.

erwanor pushed a commit that referenced this issue Apr 22, 2024
@TalDerei
auction(pcli): auction support in pcli (#4249)
64e0d7d 
## Describe your changes
Auction support in pcli

## Issue ticket number and link
References #4242

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:
@cratelyn cratelyn modified the milestones: Sprint 4, Sprint 5 Apr 22, 2024
erwanor pushed a commit that referenced this issue Apr 24, 2024
@TalDerei @erwanor
auction(pcli): auction support in pcli (#4249)
57a0541 
## Describe your changes
Auction support in pcli

## Issue ticket number and link
References #4242

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:
@erwanor erwanor mentioned this issue May 1, 2024
Merged
1 task
erwanor added a commit that referenced this issue May 1, 2024
@erwanor
pcli: improve auction rendering (#4297)
982f089 
## Describe your changes

This improve rendering of query/view subcommands for DAs. Helpful for
testing and integration work.

Closes #4242, #4243, #4244

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Client changes
@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalDerei TalDerei

Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Milestone
Sprint 5
Development

Successfully merging a pull request may close this issue.

pcli: improve auction rendering penumbra-zone/penumbra
3 participants
@erwanor @cratelyn @TalDerei