Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcli: validator-governance-subkey subcommand is in the wrong place #4214

Open
hdevalence opened this issue Apr 15, 2024 · 3 comments
Open

pcli: validator-governance-subkey subcommand is in the wrong place #4214

hdevalence opened this issue Apr 15, 2024 · 3 comments
Assignees
@erwanor @kerber0x
Labels
A-client Area: Design and implementation for client functionality _P-low Priority: low

Comments

@hdevalence
Copy link
Member

hdevalence commented Apr 15, 2024 •
edited by erwanor
Loading

Describe the bug

Running pcli init --help describes a validator-governance-subkey command that's only relevant for validators. We already have a place for commands that are only relevant for validators, namely pcli validator, and it should move there.

Prospective contributors: hit up @erwanor here or on Discord if you want to pick this up!
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 15, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 15, 2024
@erwanor erwanor removed the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 22, 2024
@aubrika aubrika added the _P-low Priority: low label Apr 24, 2024
@erwanor erwanor added help wanted Help on this issue is welcomed! good first issue A good issue for people without existing context on the project. _P-V1 Priority: slated for V1 release labels Apr 24, 2024
@cratelyn cratelyn added the A-client Area: Design and implementation for client functionality label May 6, 2024
@kerber0x
Copy link
Contributor

Would like to help with this one @erwanor

@erwanor
Copy link
Member

erwanor commented May 13, 2024

Sounds great, thanks! do you have any questions? @kerber0x feel free to open a draft pr early and we can workshop it as we go

@erwanor
Copy link
Member

erwanor commented May 13, 2024

This is a bit more squirrelly than anticipated, removed the good-first-issue tag. I will update the issue with a plan at a later time. Apologies for the churn @kerber0x

@erwanor erwanor removed help wanted Help on this issue is welcomed! good first issue A good issue for people without existing context on the project. labels May 13, 2024
@erwanor erwanor self-assigned this May 13, 2024
@aubrika aubrika removed the _P-V1 Priority: slated for V1 release label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

@kerber0x kerber0x

Labels
A-client Area: Design and implementation for client functionality _P-low Priority: low
Projects
Penumbra
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hdevalence @erwanor @cratelyn @aubrika @kerber0x