Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: 🖋️ mock consensus engine can test validator uptime measurements #4040

Closed
cratelyn opened this issue Mar 18, 2024 · 2 comments · Fixed by #4070
Closed

tests: 🖋️ mock consensus engine can test validator uptime measurements #4040

cratelyn opened this issue Mar 18, 2024 · 2 comments · Fixed by #4070
Assignees
Labels
A-mock-consensus Area: Relates to the mock consensus engine C-enhancement Category: an enhancement to the codebase
Milestone

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Mar 18, 2024

stub issue, see #3588. see #3995.

currently, the consensus keys in the keyring are not used by either the test node or block builder to sign blocks. we should introduce the ability to sign blocks, in order to test e.g. the staking component.

see section 8a in #3995. we will likely need to do some requirements discovery as part of that work, which should drive the fix to this issue.

@cratelyn cratelyn added C-enhancement Category: an enhancement to the codebase A-mock-consensus Area: Relates to the mock consensus engine labels Mar 18, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Mar 18, 2024
@erwanor
Copy link
Member

erwanor commented Mar 18, 2024

One thing to note is that the application doesn't actually verify signatures on blocks, it takes it as granted from the consensus layer (same for byzantine misbehavior evidence) so as long as mock consensus produces legible commit information (containing VoteInfos) the application will be able to track the uptime accurately.

@cratelyn
Copy link
Contributor Author

One thing to note is that the application doesn't actually verify signatures on blocks, it takes it as granted from the consensus layer (same for byzantine misbehavior evidence) so as long as mock consensus produces legible commit information (containing VoteInfos) the application will be able to track the uptime accurately.

this is very helpful to know, thank you!

@cratelyn cratelyn changed the title tests: 🖋️ mock consensus engine uses keyring to sign blocks tests: 🖋️ mock consensus engine can test validator uptime measurements Mar 18, 2024
@cratelyn cratelyn moved this from 🗄️ Backlog to In progress in Penumbra Mar 25, 2024
@cratelyn cratelyn added this to the Sprint 3 milestone Mar 25, 2024
@cratelyn cratelyn self-assigned this Mar 25, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Mar 26, 2024
cratelyn added a commit that referenced this issue Mar 26, 2024
this code was commented out when working on #4044. as of #4070,
(see #4040) we now sign blocks. let's turn this code back on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mock-consensus Area: Relates to the mock consensus engine C-enhancement Category: an enhancement to the codebase
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants