Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define RPC methods for the governance component to restore access to its functionality. #3093

Closed
hdevalence opened this issue Sep 23, 2023 · 1 comment · Fixed by #3275
Closed
Assignees
Labels
A-governance Area: Governance

Comments

@hdevalence
Copy link
Member

Is your feature request related to a problem? Please describe.

In refactoring #3091, I discovered that the client-side governance functionality used raw state read queries coordinated by Rust code, rather than making use of GRPC methods like other functionality. This makes it practically impossible for any software not part of our Rust monorepo to interact with the system, since it won't know what raw state reads to construct or how to parse their data.

The Rust code that coordinated the raw reads was removed as part of the refactoring, so the functionality is disabled for now. To restore it, we'll need to define and implement relevant RPC methods as part of the governance component's QueryService. This isn't a consensus-affecting change, so the timing isn't critical with respect to any release, but until we do it, we won't be able to interact with any governance functionality.

@redshiftzero redshiftzero added the A-governance Area: Governance label Sep 28, 2023
@aubrika aubrika moved this to Testnet 63: Rhea in Testnets Oct 6, 2023
@conorsch conorsch assigned zbuc and unassigned plaidfinch Oct 13, 2023
@conorsch
Copy link
Contributor

@zbuc will pick this up for second half of 63 sprint. This ticket is blocking further governance work, so we definitely want it in. For now, operations like voting via pcli are not working. We'd like to restore that functionality pronto.

@aubrika aubrika moved this from Testnet 63: Rhea (Web Wallet) to In Progress (Already claimed) in Testnets Oct 19, 2023
@aubrika aubrika added this to Penumbra Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Oct 30, 2023
@aubrika aubrika moved this from 🗄️ Backlog to 🏗 In progress in Penumbra Oct 30, 2023
@zbuc zbuc closed this as completed in #3275 Nov 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress (Already claimed) to Testnet 63: Rhea (Web Wallet) in Testnets Nov 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-governance Area: Governance
Projects
Archived in project
Status: Testnet 63: Rhea (Web Wallet)
Development

Successfully merging a pull request may close this issue.

5 participants