From 872f52ccfa385db2d53d27b490f3f462a3c8e968 Mon Sep 17 00:00:00 2001 From: Henry de Valence Date: Mon, 11 Mar 2024 02:26:39 -0700 Subject: [PATCH] penumbra: amend pr template (#3993) ## Describe your changes Add a prompt for people to share their reasoning about breaking changes ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only touches PR templates --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 9 +++++++++ pull_request_template.md | 7 ------- 2 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md delete mode 100644 pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 0000000000..4baa431c19 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,9 @@ +## Describe your changes + +## Issue ticket number and link + +## Checklist before requesting a review + +- [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: + + > REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF) diff --git a/pull_request_template.md b/pull_request_template.md deleted file mode 100644 index 669825a014..0000000000 --- a/pull_request_template.md +++ /dev/null @@ -1,7 +0,0 @@ -## Describe your changes - -## Issue ticket number and link - -## Checklist before requesting a review - -- [ ] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label.