From 7e8ff5555018412df98b2794c1fe4e515e197430 Mon Sep 17 00:00:00 2001 From: katelyn martin Date: Fri, 19 Apr 2024 14:26:24 -0400 Subject: [PATCH] =?UTF-8?q?feat(app):=20=F0=9F=8E=A3=20add=20missing=20`De?= =?UTF-8?q?x`=20component=20hook=20(#4247)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit see #3739, and #4246. while wiring up a pair of missing component hooks for the `Sct` component, i found another (noöp) hook that we do not include in the `App`'s control flow. this isn't currently a bug, since `::begin_block()` is a noöps but could easily lead to a surprising outcome in the future, if more logic was introduced to that trait method. #### checklist before requesting a review - [x] if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason: > while this **does** change the control flow of consensus-critical logic, this does **not** change the execution of incoming data. the hooks introduced here are noöps. --- crates/core/app/src/app/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/core/app/src/app/mod.rs b/crates/core/app/src/app/mod.rs index 12b430c39f..e64db70186 100644 --- a/crates/core/app/src/app/mod.rs +++ b/crates/core/app/src/app/mod.rs @@ -257,6 +257,7 @@ impl App { begin_block, ) .await; + Dex::begin_block(&mut arc_state_tx, begin_block).await; CommunityPool::begin_block(&mut arc_state_tx, begin_block).await; Governance::begin_block(&mut arc_state_tx, begin_block).await; Staking::begin_block(&mut arc_state_tx, begin_block).await;