Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.x #7

Open
neithere opened this issue Sep 2, 2016 · 0 comments
Open

Python 3.x #7

neithere opened this issue Sep 2, 2016 · 0 comments

Comments

@neithere
Copy link

neithere commented Sep 2, 2016

Hi Wynn,

Thank you for the app! Unfortunately, it's broken after making Python 3.5 the default version on my system.

Do you consider upgrading the code?

Looks like the only reason why the app is broken is the usage of outdated APIs. For example, items.has_key(k) is non-pythonic and was removed from Python 3. Even in Python 2.x it was recommended to write k in items. The full list of such things can be seen by running these commands:

$ sudo pip install pep8
$ pep8 /usr/local/bin/grc
$ pep8 /usr/local/bin/grcat

I would expect that simply fixing the errors and warnings would make the app work fine with modern Pythons.

I can help with some changes if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant