umpf: do not set PV in series.inc #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if the comment would break parsing at any place. As an alternative, we could also just remove the PV line. |
ejoerns
force-pushed
the
no-pv-in-series.inc
branch
2 times, most recently
from
d84f740
to
e94bcdc
Compare
lynxeye-dev
reviewed
Apr 24, 2024
ejoerns
force-pushed
the
no-pv-in-series.inc
branch
from
e94bcdc
to
b70ceff
Compare
Since most recipes tend to use PV in their SRC_URI and we cannot set it
as a default value ('?='), it is the safest way to not set it
automatically from series.inc.
Users who want to have the umpf version as part of the yocto package
version can set
PV = "${UMPF_PV}"
at an appropriate location within the recipe.
Signed-off-by: Enrico Jörns <[email protected]>
ejoerns
force-pushed
the
no-pv-in-series.inc
branch
from
b70ceff
to
91a674b
Compare
rohieb
approved these changes
Apr 25, 2024
|
This version looks good to me. |
This could be a later step indeed, but I would first like to find out what it means to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most recipes tend to use PV in their
SRC_URIand we cannot set it as a default value (?=), it is the safest way to not set it automatically from series.inc.Users who want to have UMPF_VERSION as part of the yocto package version can manually set PV to
at an appropriate location within the recipe.