Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze quotation after clicking in Confirm #298

Open
gianfra-t opened this issue Nov 22, 2024 · 5 comments
Open

Freeze quotation after clicking in Confirm #298

gianfra-t opened this issue Nov 22, 2024 · 5 comments
Labels
type:bug Something isn't working

Comments

@gianfra-t
Copy link
Contributor

The quote "Your quote.." we see after clicking the confirm button continues to be updated even after click.

This presents a problem (with ARS) given that at least for now, the user has to use that value and set it on the Anchor UI. If it has changed in the meantime, it may lead to confusions and an incorrect amount set, which will restart the process.

image
@gianfra-t gianfra-t added the type:bug Something isn't working label Nov 22, 2024
@TorstenStueber
Copy link
Collaborator

@pendulum-chain/product shall we add to the ARS epic and move to Ready?

@prayagd
Copy link
Collaborator

prayagd commented Nov 25, 2024

Yes makes sense, moved

@ebma ebma self-assigned this Nov 25, 2024
@ebma
Copy link
Member

ebma commented Nov 26, 2024

I'm putting this on hold for now as we concluded that we want to wait for Anclap to fix the automatic amount inclusion in the redirect.

@ebma ebma added the on-hold label Nov 26, 2024
@vadaynujra vadaynujra changed the title Freeze quotation after clicking in Confirm. Freeze quotation after clicking in Confirm Dec 5, 2024
@vadaynujra
Copy link

@ebma wouldn't this be required irrespective of other changes e.g. Anclap. The expected behavior is that the quote for ARS should also be frozen upon user confirmation, just like EUR. Why do we need to wait for Anclap changes?

@ebma
Copy link
Member

ebma commented Dec 12, 2024

It's nice to have but I wouldn't say it's required. It's required that the amount stays the same if you manually need to fill it in the Anclap UI. Otherwise it might just cause some confusion for the user. Do you think it's important @vadaynujra?

@ebma ebma removed the on-hold label Dec 12, 2024
@ebma ebma removed their assignment Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants