Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow to start off ramping from EVM networks #292

Closed
5 tasks
prayagd opened this issue Nov 21, 2024 · 7 comments · Fixed by #323
Closed
5 tasks

Update flow to start off ramping from EVM networks #292

prayagd opened this issue Nov 21, 2024 · 7 comments · Fixed by #323
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented Nov 21, 2024

User Story

As a user, I want to off my USDT / USDC from the following networks:

  • Ethereum
  • BSC
  • Arbitrum
  • Base
  • Avalanche

Assets

Network USDC USDT
Ethereum 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48 0xdAC17F958D2ee523a2206206994597C13D831ec7
BSC 0x8AC76a51cc950d9822D68b83fE1Ad97B32Cd580d 0x55d398326f99059fF775485246999027B3197955
Arbitrum 0xaf88d065e77c8cC2239327C5EDb3A432268e5831 0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9
Base 0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913 0xfde4C96c8593536E31F229EA8f37b2ADa2699bb2
Avalance 0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E 0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7

Acceptance criteria

  • Update the Vortex flow such that it starts the off-ramp from the above listed networks
  • Subsidy feature takes into account liquidity on the respective network
  • Network dropdown allows user to choose network to off-ramp from
  • Network selection creates a prompt for the user to change network in the wallet
  • Asset list is specific to the network chosen
  • Progress screen shows accurate asset and network
  • Deep links for 'To' and 'From' assets should also include the network selection
  • Compare fee should consider accurate asset / network
  • Changing network between EVM chains should not disconnect wallet considering wallet is connected

Note

  • Assumption: This ticket is for both frontend and backend changes, assuming configuration changes to the current setup
@prayagd prayagd transferred this issue from pendulum-chain/pendulum Nov 21, 2024
@vadaynujra vadaynujra changed the title Integrate XXX from Arbitrum network to Vortex Update flow to start off ramping from EVM networks Nov 22, 2024
@prayagd
Copy link
Collaborator Author

prayagd commented Nov 25, 2024

@pendulum-chain/devs What all things to be considered when adding support to the above listed networks and assets?

@TorstenStueber
Copy link
Collaborator

@pendulum-chain/devs how can we check/ensure that Squid router supports all these network/asset pairs?

@ebma
Copy link
Member

ebma commented Nov 25, 2024

I would again just check for routes of all the listed tokens in the squidrouter app/UI.

For example, when selecting to bridge USDC from Ethereum to Moonbeam here, the app shows a route so we know that we can use this or a similar route in vortex. We then need to check this for all tokens and if every single one of them has a route it should be possible to add all of them with little effort.

@TorstenStueber
Copy link
Collaborator

I checked them in the UI, for all five networks USDC and USDT are available, so we should be good to go.

@prayagd
Copy link
Collaborator Author

prayagd commented Nov 25, 2024

@TorstenStueber anything else to be considered before moving this ticket to ready like subsidy or anything else?

@TorstenStueber
Copy link
Collaborator

No, we might only first merge the Asset Hub tickets so that the wallet switch code will be more clear to implement.

@prayagd
Copy link
Collaborator Author

prayagd commented Nov 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants