-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert splitting of Moonbeam receiver contract #185
Comments
@pendulum-chain/product this change will also speed up the offramping process. |
Hey team! Please add your planning poker estimate with Zenhub @b-yap @gianfra-t @Sharqiewicz @TorstenStueber |
We should probably also test what Squidrouter did in the mean time. Do they really respect the |
I would personally leave the code around. Not as an automatic fallback since that would be quite a lot of work for a very unlikely scenario, but such that it's easy to plug the "new" logic back. |
@gianfra-t so the suggestion would be to have a config parameter that determines what option we want to use? Could make sense that way. |
Good point, I changed the description to reflect that. |
@ebma @TorstenStueber, Will the reduction of the overhead as a result of this change result in the off-ramp becoming quicker for the user? By how much would this change quicken flow? |
Yes. About 10-20 seconds. |
@vadaynujra moved this ticket to being prepared in the light of current priority |
Context
To work around issues introduced by the increase in gas cost on Moonbeam, the receiver contract was split into two parts for #137, resulting in additional overhead on the frontend application.
It seems like squidrouter managed to deploy a fix that works around this issue and the original logic would work again. To reduce the overhead, the splitting of the receiver contract should get reverted.
TODO
0x066d12e8f155c87a87d9db96eac0594e872c16b2
, more info here.The text was updated successfully, but these errors were encountered: