Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip waiting for finalization of ExecuteRedeem event to speed up process #184

Open
ebma opened this issue Oct 2, 2024 · 4 comments
Open

Comments

@ebma
Copy link
Member

ebma commented Oct 2, 2024

Context

At the moment, the process waits for the finalization of the redeem execution on Spacewalk. This is not necessary as it's only relevant whether the tokens arrived on the Stellar account or not. By cutting this out from the process, we can simplify the logic and save a couple of seconds.

TODO

Instead of waiting for the ExecuteRedeem event to be emitted here, the process can just check if the tokens already arrived on the Stellar account. This is already done in the error case here.

@ebma
Copy link
Member Author

ebma commented Oct 2, 2024

@pendulum-chain/product this ticket is a low-effort improvement speeding up the offramping flow. We should do it soon.

@ebma
Copy link
Member Author

ebma commented Oct 2, 2024

@vadaynujra
Copy link

@prayagd not high priority since it only quickens the off-ramp by a couple of seconds.

@prayagd
Copy link
Collaborator

prayagd commented Nov 7, 2024

@vadaynujra moved this back to being prepared in the light of current prioritization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants