Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title is not reverted to previous state when closing the modal #26

Open
janchaloupka opened this issue Jul 15, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@janchaloupka
Copy link
Member

I have encountered a problem with dynamic page title. On opening a modal the page title reflects the change. However when closing the modal the title is not updated back to its original value.

Steps to reproduce the problem:

  1. have dynamic <title> snippet that redraws when opening a modal
  2. open the modal window - the page title should have changed to the modals title
  3. now close the modal (either from site interaction or via the back button)
  4. the title does not revert to the previous value

I suspect the problem is somewhere in the history state as I noticed the page title is overwritten even for the previous history entry.

@zipper can you please look into it?

@zipper
Copy link
Contributor

zipper commented Jul 16, 2024

Solved in #27, released in https://github.com/peckadesign/pd-naja/releases/tag/2.3.1. The title is now correctly changing back.

There is still one issue remaining with the history entry itself, see naja-js/naja#406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants