Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.4.0 breaks pear/xml_rpc2 1.1.4 #18

Closed
aguvillalba opened this issue Jul 28, 2020 · 2 comments
Closed

Version 2.4.0 breaks pear/xml_rpc2 1.1.4 #18

aguvillalba opened this issue Jul 28, 2020 · 2 comments

Comments

@aguvillalba
Copy link

New version 2.4.0 is incompatible with pear/xml_rpc2 1.1.4:
PHP Warning: Uncaught ErrorException: require_once(HTTP/Request2.php): failed to open stream: No such file or directory in /home/vagrant/vendor/pear/xml_rpc2/XML/RPC2/Util/HTTPRequest.php:45

Any hint to solve this? Thank you!

@sad-spirit
Copy link
Member

Any hint to solve this?

Basically, just remove require_once 'HTTP/Request2.php' statement from the above file.

The longer answer is that I removed include-path setting from composer.json of release 2.4.0, so packages that depend on HTTP_Request2 can no longer rely on the fact that such statements work. They should only do this as a fallback if the class was not autoloaded, e.g.

if (!class_exists('HTTP_Request2', true)) {
    require_once 'HTTP/Request2.php';
}

the code above will trigger autoloading when run from composer installation and fall back to explicit require in PEAR installation.

Please open an issue for xml_rpc2 linking to this one

@aguvillalba
Copy link
Author

Thank you very much! I've created a pull request to xml_rpc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants