-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add support for template steps/configs in reports #246
Conversation
|
Strangely those search regexs all have different paths, so that part was correct. They do not represent the search and replace text properly though. Could you remind me exactly which in-UI table you're looking at, where template checkout support is missing? |
aah gotcha. Yea that is something to consider |
whoops forgot about this. Merging |
daed387
to
a2b346d
Compare
Whoops I forgot about this entirely, and had to do some merge conflict fixing. Requesting another review, nothing of substance has changed |
Co-authored-by: Zachary Lentz <[email protected]>
The test suite failures are somewhat concerning in that I don't really understand them but they aren't new. The code is the same. If you re-opened the gui yourself after this I'm 👍 on merging. |
i have re-opened the GUI... 😞 dumb conda. I'll just merge and hope this resolves itself |
Description
Adds report output for template steps/reports
More refining to do, but the start is here
Motivation and Context
Reports are basically the reason atef exists.
We probably want some better reprs for the
RegexFindReplace
classes.How Has This Been Tested?
interactively
Where Has This Been Documented?
This PR
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page