Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT/BUG: Misc fixes #213

Merged
merged 7 commits into from
Oct 2, 2023
Merged

MNT/BUG: Misc fixes #213

merged 7 commits into from
Oct 2, 2023

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Sep 29, 2023

Description

Motivation and Context

An assortment of fixes because I didn't want to work on anything big but still wanted to be a bit productive

How Has This Been Tested?

interactively

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Code has been checked for threading issues (no blocking tasks in GUI thread)
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong marked this pull request as ready for review October 2, 2023 20:26
@tangkong tangkong requested review from ZLLentz and klauer October 2, 2023 20:28
ZLLentz
ZLLentz previously approved these changes Oct 2, 2023
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these fixes look correct to me

klauer
klauer previously approved these changes Oct 2, 2023
@tangkong tangkong dismissed stale reviews from klauer and ZLLentz via 9537bb6 October 2, 2023 21:58
@tangkong tangkong requested review from ZLLentz and klauer October 2, 2023 22:00
@tangkong tangkong merged commit e1c04c8 into pcdshub:master Oct 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants