-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 Amend Network Additions #279
💥 Amend Network Additions #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itxtoledo thx for this PR. I need to think about your suggested changes since it's essentially a breaking API change for the user in the configuration due to the type change. Also, adding a new network to xdeployer
is currently a question of a minute :)
It not break the API, it adds code completion since now the user will now exactly which networks are available. |
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this refactor. I slightly adjusted the getTxHashLink
and getAddressLink
functions, using ternary operators.
Thank you for this package ! |
✅ PR Checklist
🕓 Changelog
This PR aims to achieve two things:
networksInfo
object to make it work, whereas before, you had to modify two different arrays.🐶 Cute Animal Picture