Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way for execution role policy to be adjusted #40

Open
socketbox opened this issue Nov 29, 2023 · 0 comments
Open

Provide a way for execution role policy to be adjusted #40

socketbox opened this issue Nov 29, 2023 · 0 comments

Comments

@socketbox
Copy link
Collaborator

Currently, the module relies upon the creation of an S3 bucket (which is done whether or not the user indicates that snapshots should be taken). This dependency is present in the default policy. If the user were to pass in a policy, thus overwriting the policy created by default, it would have to be overly permissive, as there would be no way to anticipate the S3 resource created by the module. This same drawback applies to a scenario whereby the user passes in an execution role ARN, thus preventing any policy or role from being created. Even adopting this last approach is awkward: it requires a targeted, two-step apply to first create the role and policy and then create the synthetic.

A more nuanced approach to modifying the policy, such as augmenting rather than overwriting the default, is even trickier. Leaving the issue of dynamic policy generation aside, the merging of two decoded JSON strings isn't trivial (in Terraform).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant