Honor network_mode of "none" #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nlicitra reported that he could not create a taskdef with no open ports and networking disabled. This PR would honor such a request on the part of the client programmer.
To create a non-networked taskdef, the user would pass in
network_mode = noneandrequires_compatibilitesto a value that does not include "FARGATE" (the default). See modulefooin the attached file for an example of this.To test, download the attached file and rename it to
main.tf. Apply it and check that it creates three task definitions: one with no networking and no open ports, the other with network mode set toawsvpcand an open port of80, and the last with a network mode set toawsvpcand an open port of8080.