Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts typings are incorrect for callbacks #51

Open
dnaustin opened this issue Mar 26, 2019 · 2 comments
Open

index.d.ts typings are incorrect for callbacks #51

dnaustin opened this issue Mar 26, 2019 · 2 comments

Comments

@dnaustin
Copy link

The definition for the search method is currently:

public search(id: string, maxResults: number, params: Object, callback: (validate?: Error) => void, data?: YtResult): void;

I believe that it should be:

public search(id: string, maxResults: number, params: Object, callback: (validate?: Error, data?: YtResult) => void): void;

I also believe that the getPlaylistItemsById and related methods also have the same problem.

@Claxtastic
Copy link

Bumping this, same issue

@Denny966
Copy link

Can also confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants