WebSocket::path() returns nullopt when state is Connecting

[murat-dogan]

I am converting ws to native WebSocket functions.
Sometimes app can not read path.

I added a workaround for now here
https://github.com/murat-dogan/node-datachannel/blob/c311c111bdd1b3c20d056f6f46a7c3c12610f8ce/examples/client-server/signaling-server.js#L11

The problem is related to this line

libdatachannel/src/websocket.cpp

Line 68 in 67e88a6

return state != State::Connecting && handshake ? make_optional(handshake->path()) : nullopt;

When onClient callback is called, it is still in Connecting state (handshake->path() is valid though)

Can we remove this condition, or there are some other reasons?

[paullouisageneau]

The onClient() callback is triggered early, as soon as the client connects with TCP. This allows the server to react on the remote address, for instance. The path is available only after handshake is finished, which happens in parallel and probably won't be finished when onClient() is scheduled. To be sure the path is available, you should read it in the onOpen() callback, which is triggered after a successful handshake.

[murat-dogan]

With ws module I can read it on-connection event
https://github.com/murat-dogan/node-datachannel/blob/63ec3215063931aae772f2acfa2c2199bfeca2b3/examples/client-server/signaling-server.js#L8

I can move it to onOpen no problem, but it will be good to have the same behaviour for general use